Ensure indentation is consistent #4312
Closed
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents mixing spaces and tabs in the same ‘block’ of code. Mixing is still allowed if each line uses the same mix and if the indentation level returns to 0. This breaks the literate coffeescript test that mixes spaces and tabs.
|
Also see the follow-up #4313, which is a even more strict (and IMHO better) proposal to prevent (accidental) whitespace mixing. |
|
Cool. If we're going to consider this, we should consider the strict version of it. Closing in favor of #4313. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #4303, but takes more or less the opposite approach:
This is a proposal to make the parser more strict, and ensure that indentation always matches the literal indentation that came before it.
It makes this code not parse anymore:
(2nd line uses a space, 3rd line a tab, this is currently legal code.)
This prevents using a different style of indentation (e.g. mixing spaces and tabs) in the same ‘block’ of code (where indentation > 0).
Mixing is still allowed if each line uses the same mix and if the indentation level returns to 0. (Each block can use it own style.)
(Breaks the literate coffeescript test that mixes spaces and tabs.)